spiral-matrix: add to track #677
Conversation
| @@ -285,6 +285,13 @@ | |||
| ] | |||
| }, | |||
| { | |||
| "slug": "spiral-matrix", | |||
| "difficulty": 6, | |||
|
|
||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
Check: is this needed per policy?
There was a problem hiding this comment.
No, according to the policy after the first 20 exercises no starter implementation needs to be provided. But quite a few exercises after the first 20 have an empty starter implementation like this. Do you think that's okay or should we make them more consistent?
There was a problem hiding this comment.
I think there's an open issue for cleanup; let's decide there whether we want no implementation or empty class(es)! #554
stkent
changed the title
| class SpiralMatrixBuilder { | ||
|
|
||
| int[][] ofSize(int size) { | ||
| if (size == 0) return new int[][]{}; |
There was a problem hiding this comment.
I would add curly brackets and put the if body on a new line, just to be safe :)
There was a problem hiding this comment.
Kotlin habits sneaking in ;)
|
|
||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
No, according to the policy after the first 20 exercises no starter implementation needs to be provided. But quite a few exercises after the first 20 have an empty starter implementation like this. Do you think that's okay or should we make them more consistent?
| @@ -0,0 +1,27 @@ | |||
| class SpiralMatrixBuilder { | |||
|
|
|||
| int[][] ofSize(int size) { | |||
There was a problem hiding this comment.
Maybe buildMatrixOfSize() would be a more descriptive name?
problem specification directory
Reviewer Resources:
Track Policies